Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dcrjson: Introduce v2 module without wallet types. #1607

Merged

Conversation

@davecgh
Copy link
Member

davecgh commented Feb 13, 2019

This removes all wallet-specific type definitions and tests from the dcrjson module since they are being moved into their own module that lives in the dcrwallet repository.

In order to accomplish this, a series of individual commits have been used been to make the review process easier. Each commits message more thoroughly describes its purpose, but primarily they all consist of either docs updates or moving commands, notifications, and results that are served by the chain server into the appropriate files since they were improperly categorized in the wallet files which is incorrect because wallet consumes them as opposed to serving them.

Finally, since this constitutes a major break to the API, it also bumps the module version to version 2.

It should also be noted that this only introduces the new module and does not update anything to make use of it yet, so building the software will still produce binaries based on the v1 module (if not using the overrides in the root module).

@davecgh davecgh added this to the 1.5.0 milestone Feb 13, 2019
@davecgh davecgh force-pushed the davecgh:dcrjson_introduce_v2_without_wallet_types branch from dace323 to f7c1f82 Feb 13, 2019
go.mod Show resolved Hide resolved
davecgh added 11 commits Feb 13, 2019
This updates README.md to call out it implements decred JSON-RPC API and
correct a style nit.
This moves the test for estimatefee to the chainsvrcmds_test.go file to
match the fact it's defined in chainsvrcmd.go.
This moves the command definitions and associated types for the
createrawsstx and createrawssrtx commands to the chainsvrcmds.go file
since they are served by the chain RPC server.
This moves the result definition for the getbestblock command to the
chainsvrresults.go file since it is served by the chain RPC server.
This moves the definition and associated code for the winningtickets
notification to the chainsvrwsntfns.go file since it is served by the
chain RPC websocket server.  It also moves the associated test to the
chainsvrwsntfns_test.go file accordingly.
This moves the definition and associated code for the
spentandmissedtickets notification to the chainsvrwsntfns.go file since
it is served by the chain RPC websocket server.  It also moves the
associated test to the chainsvrwsntfns_test.go file accordingly.
This moves the definition and associated code for the stakedifficulty
notification to the chainsvrwsntfns.go file since it is served by the
chain RPC websocket server.
This moves the definition and associated code for the newtickets
notification to the chainsvrwsntfns.go file since it is served by the
chain RPC websocket server.  It also moves the associated test to the
chainsvrwsntfns_test.go file
This removes all wallet-specific type definitions and tests from the
dcrjson module since they are being moved into their own module that
lives in the dcrwallet repository.

Since this constitutes a major break to the API, it also bumps the
module version to version 2.
This updates the docs/README.md file, module hierarchy graphviz, and
module hierarchy diagram to reflect the new module version.
@davecgh davecgh force-pushed the davecgh:dcrjson_introduce_v2_without_wallet_types branch from 0a43747 to 9265b40 Feb 14, 2019
@jrick
jrick approved these changes Feb 14, 2019
@davecgh davecgh merged commit 9265b40 into decred:master Feb 14, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@davecgh davecgh deleted the davecgh:dcrjson_introduce_v2_without_wallet_types branch Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.