Waste less memory if sighash optimizations are on #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tACK on simnet |
| tx *wire.MsgTx, idx int) (chainhash.Hash, error) { | ||
| var buf bytes.Buffer | ||
| if hashType&sigHashMask != SigHashAllValue { | ||
| binary.Write(&buf, binary.LittleEndian, |
There was a problem hiding this comment.
Please avoid binary.Write, especially since this is supposed to be an optimized hot path. Call the methods on binary.LittleEndian instead.
|
@alexlyp Please turn on the optimization in chaincfg/params.go and then sync mainnet and testnet too |
|
with optimization = true sync on testnet and mainnet went fine |
cjepson
force-pushed
the
cj_130516txveropt
branch
from
854c307
to
b7b0077
Compare
Legacy transaction deep copy code mandated by the Bitcoin protocol caused large amounts of data to be copied needlessly. If the optimization for SigHashAll is set in chaincfg/params.go, these extra copies are avoided by directly writing the pkScript and decorations to a buffer and then hashing to get a witness hash, while using the cached hash for the prefix. Fixes btcsuite#126.
cjepson
force-pushed
the
cj_130516txveropt
branch
from
b7b0077
to
653e13d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legacy transaction deep copy code mandated by the Bitcoin protocol
caused large amounts of data to be copied needlessly. If the
optimization for SigHashAll is set in chaincfg/params.go, these
extra copies are avoided by directly writing the pkScript and
decorations to a buffer and then hashing to get a witness hash,
while using the cached hash for the prefix.
Fixes #126.