secp256k1: No allocs in slow scalar base mult path. #3225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrick
approved these changes
Mar 21, 2024
This moves the conversion of the base point represented in Jacobian coordinates outside of the slow scalar base multiplication path used in resource constrained environments to avoid unnecessary allocations. name old time/op new time/op delta -------------------------------------------------------------------------------- ScalarBaseMultNonConstSlow 91.9µs ± 1% 91.5µs ± 1% ~ (p=0.280 n=10+10) name old alloc/op new alloc/op delta -------------------------------------------------------------------------------- ScalarBaseMultNonConstSlow 64.0B ± 0% 0.0B -100.00% (p=0.000 n=10+10) name old allocs/op new allocs/op delta -------------------------------------------------------------------------------- ScalarBaseMultNonConstSlow 2.00 ± 0% 0.00 -100.00% (p=0.000 n=10+10)
davecgh
force-pushed
the
secp256k1_no_allocs_for_slow_base_mult
branch
from
457ba1d
to
fe9a28c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is rebased on #3224.
This moves the conversion of the base point represented in Jacobian coordinates outside of the slow scalar base multiplication path used in resource constrained environments to avoid unnecessary allocations.