Optimize mining checks for various stake transactions #83
Conversation
|
|
||
| if isSSGen, _ := stake.IsSSGen(tx); isSSGen { | ||
| txType := txDesc.Type | ||
| isSSGen := txType == stake.TxTypeSSGen |
There was a problem hiding this comment.
I know this is legal go, but I kind of think lines like that are very hard to read when going through it quickly. Is there any clearer way to do it?
|
Other than the comments above this looks fine. Someone who mines needs to test for real though. |
Many of the checks for the type of stake transaction in the main sorting loop for mempool transactions of NewBlockTemplate were redundant. Now the cached data for the transaction type is used instead. An expensive lookup for a transaction cache was also moved for efficiency.
cjepson
force-pushed
the
cj_040316votecheck
branch
from
13088bd
to
db3e406
Compare
|
I cleaned up the extra declaration for the first case, but I think it's still as clean as it gets in the second case. The alternative is declaring all the vars and then doing a switch on the txType, which I think is ugly, or just not using a bool for them altogether and using equates to constants, which I think is ugly too. |
|
ntACK |
|
@cjepson fair enough about the second case, it is choosing between ugly and ugly. So just waiting for the tACK and good to go. |
|
Mined 70 blocks with this, nothing out of the ordinary noticed. tACK |
Many of the checks for the type of stake transaction in the main sorting
loop for mempool transactions of NewBlockTemplate were redundant. Now the
cached data for the transaction type is used instead. An expensive lookup
for a transaction cache was also moved for efficiency.