From 870408f6d348e27a1b55815ba3f6319b32f3d9a1 Mon Sep 17 00:00:00 2001
From: martonp <marci93@gmail.com>
Date: Tue, 7 Dec 2021 06:20:05 +0400
Subject: [PATCH] Update harness test

---
 client/asset/eth/nodeclient_harness_test.go | 36 +++++++++++++--------
 1 file changed, 22 insertions(+), 14 deletions(-)

diff --git a/client/asset/eth/nodeclient_harness_test.go b/client/asset/eth/nodeclient_harness_test.go
index 4f110b1efb..b9e09e175e 100644
--- a/client/asset/eth/nodeclient_harness_test.go
+++ b/client/asset/eth/nodeclient_harness_test.go
@@ -740,15 +740,16 @@ func testRedeem(t *testing.T) {
 	}
 
 	tests := []struct {
-		name           string
-		sleep          time.Duration
-		redeemerClient *nodeClient
-		redeemer       *accounts.Account
-		swaps          []*asset.Contract
-		redemptions    []*asset.Redemption
-		isRedeemable   []bool
-		finalStates    []dexeth.SwapStep
-		addAmt         bool
+		name            string
+		sleep           time.Duration
+		redeemerClient  *nodeClient
+		redeemer        *accounts.Account
+		swaps           []*asset.Contract
+		redemptions     []*asset.Redemption
+		isRedeemable    []bool
+		finalStates     []dexeth.SwapStep
+		addAmt          bool
+		expectRedeemErr bool
 	}{
 		{
 			name:           "ok before locktime",
@@ -814,10 +815,11 @@ func testRedeem(t *testing.T) {
 			addAmt:         false,
 		},
 		{
-			name:           "duplicate secret hashes",
-			sleep:          time.Second * 8,
-			redeemerClient: participantEthClient,
-			redeemer:       participantAcct,
+			name:            "duplicate secret hashes",
+			expectRedeemErr: true,
+			sleep:           time.Second * 8,
+			redeemerClient:  participantEthClient,
+			redeemer:        participantAcct,
 			swaps: []*asset.Contract{
 				newContract(lockTime, secretHashes[7], 1),
 				newContract(lockTime, secretHashes[8], 1),
@@ -885,6 +887,12 @@ func testRedeem(t *testing.T) {
 		}
 
 		tx, err := test.redeemerClient.redeem(ctx, test.redemptions, maxFeeRate, 0)
+		if test.expectRedeemErr {
+			if err == nil {
+				t.Fatalf("%s: expected error but did not get", test.name)
+			}
+			continue
+		}
 		if err != nil {
 			t.Fatalf("%s: redeem error: %v", test.name, err)
 		}
@@ -895,7 +903,7 @@ func testRedeem(t *testing.T) {
 			t.Fatalf("%s: redeemer pending in balance error: %v", test.name, err)
 		}
 
-		if test.addAmt && dexeth.WeiToGwei(bal.PendingIn) != uint64(numSwaps) {
+		if test.addAmt && dexeth.WeiToGwei(bal.PendingIn) != uint64(len(test.swaps)) {
 			t.Fatalf("%s: unexpected pending in balance %s", test.name, bal.PendingIn)
 		}