client/comms: expire requests on connection shutdown #1915
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids hangs on shutdown with comms requests that would be waiting to timeout.
Since the connection dropping does not abort requests (and should not since there is a reconnect loop), we must call the expire func when the wsConn is explicitly shutdown, otherwise users of
Request
andRequestWithTimeout
may hang until the request timeout is reached, depending on the use pattern.For example, with this pattern used throughout the client, it would hang at
<-errChan
until timeout even if theconn
were explicitly shutdown after sending the request: