client/eth: Add send tx fee estimate buffer #2234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martonp
changed the title
This adds a 20% buffer to the send tx fee estimate in order to not return an error from the send function when the base fee rises between the time the estimate is done and the ETH is sent.
martonp
force-pushed
the
ethFeeEstimateBuffer
branch
from
b7fdb95
to
3ba3cd6
Compare
JoeGruffins
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a 20% buffer to the send tx fee estimate in order to not return an error from the send function when the base fee rises between the time the estimate is done and the ETH is sent.
Closes #2186