enablevoting=0 in dcrwallet conf

[jholdstock]

No description provided.

[JoeGruffins]

Is the redundancy a problem?

[jholdstock]

The problem is that enablevoting=1 will cause dcrwallet to vote without respecting the users votebits. stakepoold does the voting with the correct votebits.

[JoeGruffins]

That's a pretty big deal.

[itswisdomagain]

@jholdstock Is there a way to ensure at runtime that this dcrwallet config value is correctly set? It could be so easy to miss resulting in the issue you described above.

Or use gRPC to set dcrwallet voting instructions when a user updates his voting prefs. https://github.com/decred/dcrwallet/blob/master/rpc/documentation/api.md#setvotechoices.

I'm leaning towards the second option, and even discontinuing voting with stakepoold. dcrwallet is needed to generate the vote tx afterall, so stakepoold cannot even vote if dcrwallet is down. Why not just let dcrwallet handle it all?

[JoeGruffins]

@itswisdomagain can there be different votes for different tickets that way?

[itswisdomagain]

Missed that @JoeGruffins. It cannot, currently.

@itswisdomagain can there be different votes for different tickets that way?

So I guess we look for a way to ensure at runtime that the dcrwallet enablevoting config value is correctly set.

[JoeGruffins]

We can get it through walletinfo https://github.com/decred/dcrwallet/blob/51900c2bd053bcca091d030611b6ada482719220/rpc/jsonrpc/methods.go#L3477

[chappjc]

The problem is that enablevoting=1 will cause dcrwallet to vote without respecting the users votebits. stakepoold does the voting with the correct votebits.

In addition to the possibility of improper votebits, one idea of having stakepoold create the vote (using dcrwallet to sign it) was to avoid relying on dcrwallet to track stakepool user tickets. In fact, stakepooluserinfo is one of those things that dcrwallet should strive to eliminate, along with all other stake pool realted stuff.

[chappjc]

BTW, I'm extremely surprised that the sample didn't already have enablevoting=0.