createtx: Add change output to size estimation. #2057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A multisig transaction will sometimes need a change output. Add that scipt size to the worst case size estimation that is used in fee calculation.
matheusd
approved these changes
Jun 3, 2021
| feeSize := txsizes.EstimateSerializeSize(scriptSizes, msgtx.TxOut, 0) | ||
| // Add change if we need it. | ||
| changeSize := 0 | ||
| if totalInput > amount+feeEstForTx { |
There was a problem hiding this comment.
This isn't exactly right, since it could be the case that totalInput is greater than amount+feeEstForTx but lower than the dust limit, which shouldn't create a change amount, but since feeEstForTx is significantly overestimated (0.5 dcr) this shouldn't happen in ordinary usage.
Fixing this edge case (dust limit change) would require tweaking this entire function to do a proper fee estimation, so unless this is really needed, the proposed change fixes the original issue.
jrick
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1972