Avoid needless balance calculations from ticket autobuyer #2203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajohi
approved these changes
Mar 13, 2023
Probably should be "avoiding". |
davecgh
approved these changes
Mar 13, 2023
When the ticketbuyer.balancetomaintainabsolute flag is unset/zero, there is no reason that the account balance needs to be calculated. On busier wallets, avoiding this results in a significant performance improvement. This flag is already broken for a different reason (change can land in other accounts, causing the account balance to drop below this setting) but there are still some people using the flag despite this, and compensating by setting it higher than they need.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the ticketbuyer.balancetomaintainabsolute flag is unset/zero,
there is no reason that the account balance needs to be calculated.
On busier wallets, avoid this results in a significant performance
improvement.
This flag is already broken for a different reason (change can land in
other accounts, causing the account balance to drop below this
setting) but there are still some people using the flag despite this,
and compensating by setting it higher than they need.