New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[trezor] initial trezor support #1547

Merged
merged 13 commits into from Dec 3, 2018

Conversation

Projects
None yet
2 participants
@matheusd
Member

matheusd commented Jul 24, 2018

Part of #1491

This is meant to be the first trezor related PR. This will not support staking for the moment, only wallet creation, transaction and message signing.

Checklist for things still missing:

  • Wait for decred/dcrwallet#1189 to be merged and update grpc
  • Wait for a fix to #1490 so that ticket purchasing is hidden
  • Remove instrumentation and disable trezor debug by default
  • Get people to test it

@matheusd matheusd force-pushed the matheusd:trezor branch from 14d0fd9 to 54101e0 Aug 16, 2018

@matheusd matheusd force-pushed the matheusd:trezor branch 2 times, most recently from 5fc980e to 47d5f19 Oct 9, 2018

@matheusd matheusd referenced this pull request Oct 19, 2018

Open

Trezor Support #1491

19 of 21 tasks complete

@matheusd matheusd force-pushed the matheusd:trezor branch from 47d5f19 to 92711a7 Oct 23, 2018

@matheusd matheusd force-pushed the matheusd:trezor branch 8 times, most recently from d7b1580 to 1c94326 Oct 30, 2018

@matheusd matheusd changed the title from [wip] [trezor] initial trezor support to [trezor] initial trezor support Oct 30, 2018

@matheusd

This comment has been minimized.

Member

matheusd commented Oct 30, 2018

Ready to start last round of tests for merging. Yay! 🎉

matheusd added some commits Jul 6, 2018

@matheusd matheusd force-pushed the matheusd:trezor branch from f3ba826 to 0e37d17 Nov 30, 2018

@matheusd

This comment has been minimized.

Member

matheusd commented Nov 30, 2018

Rebased against latest master

matheusd added some commits Oct 23, 2018

@matheusd matheusd force-pushed the matheusd:trezor branch from 0e37d17 to f5cd803 Nov 30, 2018

@alexlyp

This comment has been minimized.

Member

alexlyp commented Dec 3, 2018

tested and confirmed everything works as expected with Model T on testnet, going to start reviewing code now.

As discussed with @matheusd we will most likely hide this functionality behind a config setting until more issues are found/fixed and UX/UI is smoothed out.

@alexlyp

alexlyp approved these changes Dec 3, 2018

Great work as usual!

@alexlyp alexlyp merged commit f5eacd4 into decred:master Dec 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@matheusd matheusd deleted the matheusd:trezor branch Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment