Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[launcher] Add pipetx to wallet on win32 platform #2017

Merged
merged 1 commit into from Feb 27, 2019

Conversation

@matheusd
Copy link
Member

commented Feb 6, 2019

Requires #2009

This adds the pipetx flag to wallet initialization when running on the windows platform, so that the app can perform correct fetching of the grpc port during wallet startup and allows us to get rid of port detection via logs, which is brittle.

This requires the app to be compiled with an electron version 4 or higher, due to the correct function only being available on libuv 1.23+.

When testing this you might need to remove the entire node_modules and app/node_modules for the correct version of the module to be compiled. The win32ipc module does not work when using yarn build && yarn start, only with either yarn dev or yarn package.

Close #1712.

[launcher] Add pipetx in win32
After upgrading to electron 4+, libuv now provides the appropriate
function so that the file descriptor can be exported from the win32ipc
module and used during the launching process in windows.

@matheusd matheusd force-pushed the matheusd:pipetx-win branch from 75de995 to a7e4b21 Feb 19, 2019

@matheusd

This comment has been minimized.

Copy link
Member Author

commented Feb 19, 2019

Rebased and re-tested after #2009 merge.

@alexlyp alexlyp merged commit 16ae026 into decred:master Feb 27, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.