Add RFP flag to proposals list #3118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jholdstock
reviewed
Jan 8, 2021
| @@ -69,7 +85,11 @@ const ProposalsListItem = ({ | |||
| ) : ( | |||
| <div className={styles.voteResult}> | |||
| {quorumPass ? ( | |||
| voteResult | |||
| linkto && !approved && voteResult !== "declined" ? ( | |||
| <T id="proposals.rfpRejected" m="Request not chosen" /> | |||
There was a problem hiding this comment.
This is a proposal, not a request, so a better string is probably "Proposal not chosen"
| <div className={styles.proposedToRfp}> | ||
| <T | ||
| id="proposal.overview.proposedToRfp.label" | ||
| m="Proposed for {linkto}" |
There was a problem hiding this comment.
I'd suggest using the long name here as well as the ID, eg:
Proposed for The Decred Citadel: The Grand Capital (f84ed1f)
Add liked proposal name
|
Thanks for the correction and suggestion @jholdstock. I've adopted them. |
vctt94
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #3108 through the following resolutions:
1 - Quorum Not Met;
2 - Declined;
3 - Request Not Chosen (Proposed for RFP, only).