Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache: Invalid votes being incorrectly added #881

Closed
lukebp opened this issue May 17, 2019 · 0 comments

Comments

@lukebp
Copy link
Member

commented May 17, 2019

Invalid votes, such as duplicate votes, are currently being added to the cache even though they were rejected by politeiad. This is causing an incorrect vote tally to be returned from politeiawww. An example of this is the EXMO proposal. There are only 9000 votes in the votes journal for the proposal, but the proposals site is currently displaying a vote total of 9123 votes.

Most decred plugin commands return an error from politeiad when an error occurs. The ballot decred plugin command is unique in that it still returns a valid response and includes the error in the vote receipt. The cache wasn't checking the vote receipt for errors and was incorrectly treating these votes as valid.

This is a minor issue that can be fixed by adding some extra validation to the cache and rebuilding it. The integrity of the politeiad git repos is not affected.

@lukebp lukebp self-assigned this May 17, 2019

@lukebp lukebp added this to Done in pi May 17, 2019

@lukebp lukebp closed this May 17, 2019

@lukebp lukebp moved this from Done to Deployed in pi May 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
1 participant
You can’t perform that action at this time.