Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for RFP proposals/submissions #2848

Merged
merged 24 commits into from Aug 30, 2022
Merged

feat: Add support for RFP proposals/submissions #2848

merged 24 commits into from Aug 30, 2022

Conversation

victorgcramos
Copy link
Member

@victorgcramos victorgcramos commented Aug 11, 2022 •
edited

This PR adds support for RFP Proposals and Submissions for both
Home and Details pages.

Closes #2816

  • RFP tag tooltip explaining what is an RFP Proposal
  • Show RFP submissions for given RFP Proposal
  • Get expired timestamps for RFP proposals
  • link RFP Submission to its corresponding RFP Proposal
  • E2E tests for RFP Proposals and Submissions on Home and Details pages.

Preview

Screen Shot 2022-08-17 at 5 16 25 PM

Screen Shot 2022-08-17 at 5 21 27 PM

Screen Shot 2022-08-17 at 5 00 56 PM

Screen Shot 2022-08-17 at 5 00 22 PM

@victorgcramos
feat: Add support for RFP proposals/submissions
e9e9ce2
@victorgcramos
feat: add RFP tag on proposal title
57f2c9c
@victorgcramos
feat: improve rfp tag design
2100fa4
@victorgcramos
feat: add tooltip text on RFP tag
6581522
@victorgcramos
fix: typo
c9e8aeb
@victorgcramos
wip: add rfp submissions view
2c10ff3
@victorgcramos
feat: rfp submissions vote summaries
73d0316
@victorgcramos
feat: fetch rfp submissions comments counts
a7bc4f7
@victorgcramos
feat: fetch rfp proposals pi summaries
4fd340b
@victorgcramos
feat: get rfp submissions data on details page
6615ba3
@victorgcramos
style: remove logs
cc0ca97
@victorgcramos
feat: display rfp submissions list
0b234fe
@victorgcramos
fix: show rfp proposal status changes
378d22f
@victorgcramos
feat: add rfp proposal expiration timestamp
202b874
@victorgcramos
fix: show 0 comments counts
3fa5727
@victorgcramos
style: show expired timestamp first
9be955d
@victorgcramos
fix: show rfp submissions only for approved rfps
12e02f4
@victorgcramos
feat: get home linked proposal for rfp submissions
9888bbc
@victorgcramos
feat: show rfp linked proposal on details page
8ea5b12
@victorgcramos
chore: sync master and fix conflicts
5a6ca33
@victorgcramos
test: add e2e tests for rfp on home page
74a2b10
@victorgcramos
test: add e2e tests for rfp on details page
c0e08c6
@victorgcramos victorgcramos marked this pull request as ready for review August 17, 2022 20:26
tiagoalvesdulce
tiagoalvesdulce requested changes Aug 25, 2022
View reviewed changes
Copy link
Member

@tiagoalvesdulce tiagoalvesdulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a RFP proposal status changes to public with a non-empty reason, it's showing a warning:

Screen Shot 2022-08-25 at 13 43 45

tiagoalvesdulce
tiagoalvesdulce approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@tiagoalvesdulce tiagoalvesdulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@tiagoalvesdulce tiagoalvesdulce merged commit c27c845 into decred:master Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagoalvesdulce tiagoalvesdulce tiagoalvesdulce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[plugin-architecture] Add support for RFP proposals and submissions
2 participants
@victorgcramos @tiagoalvesdulce