Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for listing on decred.org #458

Merged
merged 6 commits into from
Dec 6, 2023
Merged

Conversation

jholdstock
Copy link
Member

This PR consolidates all VSP documentation into this repo. The process for listing a VSP is not really reading for a general user, so does not really belong on docs.decred.org.

This file is an exact copy of the dcrdocs file.
Remove dcrdocs specific formatting. Remove some redundant/outdated
requirements.
@jholdstock
Copy link
Member Author

jholdstock commented Nov 10, 2023

decred/dcrdocs#1235

@xaur
Copy link

xaur commented Nov 10, 2023

Minor but common issue was expiring certificates. It may be the norm expected from server operators and I'm not sure it is worth mentioning in listing.md.

Copy link
Member

@davecgh davecgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads fine, but I did notice some changes versus the docs its replacing on docs.decred.org.

Most of the changes make sense to, but I'm not sure the bits about sys admin and compilation capabilities should be removed. That is rather important I think.

I also don't think the requirement for the web front end being separate from the voting wallets should be removed. I realize it allows one less machine, but it also is like a beacon for attackers to take out one of the wallets because they'll know its IP is one and the same.

@jholdstock
Copy link
Member Author

Thanks for the reviews. I figured that "dedicated machine for web front-end" was clear enough, but I guess that isn't strictly the same as having a different IP.

@jholdstock jholdstock merged commit 4f89271 into decred:master Dec 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants