Perhaps we can now unexpose removeAttr from the API? #100

Open
wants to merge 1 commit into
from

Projects

None yet

4 participants

@aawwawa
Contributor
aawwawa commented Nov 26, 2012

Clean APIs are nice, right?

@aawwawa
Contributor
aawwawa commented Nov 26, 2012

Make for lighter docs, too...

@rvagg
Collaborator
rvagg commented Oct 14, 2013

I'm fine with this too as long as we can have some tests (sorry for the 11 month delay on commenting!)

@ryanve
ryanve commented on 07dbc05 Oct 14, 2013

It would have to be only (opt_v === null) there because undefined is a get and '' is a set.

@ryanve
Contributor
ryanve commented Oct 14, 2013

removeAttr() should stay exposed for jQuery compatibility.

@rvagg
Collaborator
rvagg commented Oct 14, 2013

good call @ryanve, I didn't know that was a jQuery thing.

@ded
Owner
ded commented Oct 15, 2013

strange. so what needs to change or not change?

@ded
Owner
ded commented Oct 15, 2013

i see. yes. if we keep it, then that is correct, we should just make it check for null

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment