Should remove need for bonzo.create()ing markup. #104

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

aawwawa commented Nov 28, 2012

Changed constructor function Bonzo.

Should remove need for bonzo.create()ing markup.
Changed constructor function `Bonzo`.
- elements :
- [elements]
+ elements = typeof elements === 'string' &&
+ !/^\s*</.test(elements) &&
@ded

ded Nov 28, 2012

Owner

this regex literal won't work in IE

@aawwawa

aawwawa Nov 29, 2012

Contributor

Garrrrh, really? What about it? Would !new RegExp("^\\s*<").test(elements) be any better?

I actually have IE, but unfortunately I'm not firing it up to test this, since every time I open it, it crashes my machine. :(

@rvagg

rvagg Nov 29, 2012

Collaborator

Hmm.. I'm not sure it's actually going to be a problem as-is in IE. You could paren for clarity: !(/^\s*</).test(elements).
In any case, a good unit test suite will pick up any problems with old IE so working on that should be your next task to figure out.

If you want a full IE test suite then you can download and use these virtual machine images direct from Microsoft exactly for this purpose: http://www.microsoft.com/en-us/download/details.aspx?id=11575

@aawwawa

aawwawa Nov 30, 2012

Contributor

Yeah, I suppose I should've said it tends to crash my machine... I gave it a try with all my work saved, and it ended up working. So I know it def works with IE8, not to say anything of the others, because this prints falsetrue.

I'll work on the test suite some time soon, though I may (or may not) need some pointers when I do. :)

@ded

ded Oct 21, 2013

Owner

yeah. what i meant was that it just needed the parens..... 11 months later

Collaborator

rvagg commented Oct 14, 2013

still interested in this @aawwawa, I'm keen if you can cook up some tests for it, just some basic stuff to test the query() path and the normalize() path if you can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment