Fixed offset function for objects in iframes. #114

Open
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
@velocityzen

So. It passed tests of course.

getWindowScroll() function had some bugs.

  1. pageXOffset and pageYOffset properties not supported by IE 8 and earlier
  2. When you trying to get offset for node in iframe, getWindowScroll must return scroll inside iframe. Not for global window.
@rvagg

This comment has been minimized.

Show comment Hide comment
@rvagg

rvagg Apr 13, 2013

Collaborator

hey @velocityzen, any chance you could think up some additional tests for these to demonstrate the original problem(s) so we don't get regressions in future?

Collaborator

rvagg commented Apr 13, 2013

hey @velocityzen, any chance you could think up some additional tests for these to demonstrate the original problem(s) so we don't get regressions in future?

@velocityzen

This comment has been minimized.

Show comment Hide comment
@velocityzen

velocityzen Apr 19, 2013

Yeah.

Yeah.

@rvagg

This comment has been minimized.

Show comment Hide comment
@rvagg

rvagg Oct 14, 2013

Collaborator

how are we going on those tests @velocityzen, any brilliant ideas to be able to capture this as a test case?

Collaborator

rvagg commented Oct 14, 2013

how are we going on those tests @velocityzen, any brilliant ideas to be able to capture this as a test case?

@velocityzen

This comment has been minimized.

Show comment Hide comment
@velocityzen

velocityzen Oct 14, 2013

Hello. Don't have a time for this, sorry. Test case is simple. Just check element positioning inside iframe!

Hello. Don't have a time for this, sorry. Test case is simple. Just check element positioning inside iframe!

@rvagg

This comment has been minimized.

Show comment Hide comment
@rvagg

rvagg Oct 14, 2013

Collaborator

will leave this open for now in case anyone else has time to add tests for this, otherwise it'll probably just be closed at some point in the future.

Collaborator

rvagg commented Oct 14, 2013

will leave this open for now in case anyone else has time to add tests for this, otherwise it'll probably just be closed at some point in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment