IE8/9 (XDomainRequest): throw if cross scheme #201

Merged
merged 2 commits into from Dec 20, 2015

Projects

None yet

3 participants

@OliverJAsh
Contributor

/cc @janua

@OliverJAsh
Contributor

(Not tested)

@ded
Owner
ded commented Jul 14, 2015

This is good. Perhaps we can clean up the error message to simply be XDomainRequest: requests must be targeted to the same scheme as the hosting page. and we can leave the URL in the source as a comment.

@OliverJAsh
Contributor

Done! I will test if you're happy with how this looks.

@ded
Owner
ded commented Jul 15, 2015

looks good.

@OliverJAsh
Contributor

I had to workaround #202, but it works:

image

/cc @janua

@janua
janua commented Jul 15, 2015

This is great!
If we can see this in our console when testing it it will point us in the right direction. Currently all you see is Access is denied in the IE 9 console and it's very difficult to diagnose what actually happened.

@ded
Owner
ded commented Jul 15, 2015

@janua are you saying that in IE9 there's no error message to a line number?

@OliverJAsh
Contributor

@janua I think he's saying that the error message isn't very helpful because it doesn't say what the error actually is, nor what it is caused by. Just "access is denied".

@janua
janua commented Jul 16, 2015

@ded @OliverJAsh Yep, I get this.

SCRIPT5: Access is denied.
<current path>, line 1 character 1.

Not very helpful at all.

@OliverJAsh
Contributor

Can we merge this please? Just ran into it again!

@ded ded merged commit 22da21c into ded:master Dec 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment