Conversation
Add default_root_store_arc() returning Arc<RootCertStore> so callers share the cached store via refcount instead of cloning the full set.
Split the cached BrowserEmulator by OS (iOS/macOS) so os_type is set at initialization time. This avoids a deep clone on every build_safari_settings call via Arc::make_mut.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two performance optimizations in builder hot paths:
primp)Split the
OnceLockcache byBrowserEmulatorOS(iOS/macOS) soos_typeis set at initialization time. This eliminates anArc::make_mutdeep clone on everybuild_safari_settingscall.primp-reqwest)Added
default_root_store_arc()returningArc<RootCertStore>socallers share the cached store via refcount increment instead of
cloning the full certificate set.