"Use of uninitialized value" error message if call 'fetchware new' #1

Closed
wbiker opened this Issue Nov 27, 2013 · 1 comment

Projects

None yet

2 participants

@wbiker

I invoked fetchware with the new parameter and a string as name:
fetchware new freetds
It worked but the first two lines are error messages:
Use of uninitialized value in string eq at /usr/local/share/perl5/App/Fetchware/Util.pm line 1152.
Use of uninitialized value in string eq at /usr/local/share/perl5/App/Fetchware/Util.pm line 1152.

I looked at the code and there is the line:
#if (not defined $) {
1152 if ($
eq undef) {

I don't know the reason, but the if clause should not be commented out?

System:
Korora 19 (Fedora)

@deeelwy deeelwy added a commit that referenced this issue Nov 30, 2013
@deeelwy Fixed github issue #1: "uninitialized" error message in fetchware new.
When gutting fetchware of all cool given/whens I switched around Aristotle's
cool forking idiom
(http://blogs.perl.org/users/aristotle/2012/10/concise-fork-idiom.html) from the
one that uses given/when to the one that does not. I changed the "if not defined
$kid" part to something else, so I could use a fetchware style heredoc long error
message, but I commented out the right code, and the test code to replace it was
wrong. It's functionally the same, but it spits out annoying error messages,
because I use $kidpid before checking its definedness. Now, I just stick with
the more correct, but kinda wonky looking "if not defined $kidpid".
cf406f1
@deeelwy
Owner
@deeelwy deeelwy closed this Dec 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment