the new parameter don't ask for a program name #2

Closed
wbiker opened this Issue Nov 27, 2013 · 2 comments

Comments

Projects
None yet
2 participants

wbiker commented Nov 27, 2013

I created a new fetchwarefile with the new parameter and once done I answered Yes to let it run.
This run failed because the program name was not ask.
Command line:
fetchware new freetds
-> asked for URL: OK
-> asked for mirror: Mantadory, but I did not find a mirror on the freetds page. Entered the same URL again
->asked for filter: Let it empty. OK
-> asked for conf options: No OK
-> asked for editing manually: No OK
-> asked for running the fetchwarefile: Yes OK
= Failed because program name is not set: NOT OK.
BTW. I am sure somewhere is mentioned where the fetchwarefiles lies. The error message says I have to edit the fetchwarefile, but does not say where I can find it.

System:
Korora 19 (Fedora)

Owner

deeelwy commented Nov 30, 2013

On Wed, 27 Nov 2013 00:37:19 -0800
Wolf notifications@github.com wrote:

I created a new fetchwarefile with the new parameter and once done I answered Yes to let it run.
This run failed because the program name was not ask.
Command line:
fetchware new freetds
-> asked for URL: OK
-> asked for mirror: Mantadory, but I did not find a mirror on the freetds page. Entered the same URL again
->asked for filter: Let it empty. OK
-> asked for conf options: No OK
-> asked for editing manually: No OK
-> asked for running the fetchwarefile: Yes OK
= Failed because program name is not set: NOT OK.
BTW. I am sure somewhere is mentioned where the fetchwarefiles lies. The error message says I have to edit the fetchwarefile, but does not say where I can find it.


Reply to this email directly or view it on GitHub:
#2

This bug was caused by a botched removal of given/when. I used vim's awesome
old school substitution feature to update all of these similar lines quickly,
which caused me to mess up the regex, and modify the right lines, the if and elsifs), and the wrong lines, the subroutine calls.

I uploaded a new release of fetchware (1.008) to fix this bug and the other 2
you reported. The fix is in commit cf406f1 .
6b32717
So just upgrade your install of fetchware to the latest version (1.008), and it should fix this problem.

Owner

deeelwy commented Dec 12, 2013

In addition to the bug fix in fetchware 1.008, in version 1.009 I have also added tests to fetchware's internal run() subroutine that executes fetchware's command-line interface. As well as tests for fetchware's actual command line interface--where fetchware is actually executed, and its interface is tested.

This way any problems with the command line interface will cause errors in fetchware's test suite, so they will be determined before release instead of allowing a bug fix to cause the command line interface to silently fail, because there was no test suite for it.

@deeelwy deeelwy closed this Dec 12, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment