Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to most recent MS SQL Server JDBC Driver version for JDK 8 #1026

Merged
merged 3 commits into from
Mar 16, 2022

Conversation

tfr42
Copy link
Member

@tfr42 tfr42 commented Dec 9, 2019

This PR upgrades the JDBC driver for MS SQL Server to the most recent version for JDK 8 which is available from maven central.

@mprins
Copy link

mprins commented Dec 9, 2019

FYI; You might want to skip this version and either use 7.2.x or use 8.1.x (currently in RC status)
There are issues with tables and columns that have underscores in their name in the 7.3.x/7.4.x releases see eg. microsoft/mssql-jdbc#1136

@tfr42
Copy link
Member Author

tfr42 commented Dec 11, 2019

@mprins Thanks! We do need a JDBC driver type IV with SQL Server 2017/SQL Server 14.0 and SQL Server 2012/SQL Server 11.0 support. Reading the https://docs.microsoft.com/en-us/sql/connect/jdbc/microsoft-jdbc-driver-for-sql-server-support-matrix?view=sql-server-ver15 we can downgrade to 7.2

@tfr42
Copy link
Member Author

tfr42 commented Dec 11, 2019

Downgraded to 7.2.2

@tfr42 tfr42 added the enhancement enhancement or improvement label Dec 11, 2019
@tfr42
Copy link
Member Author

tfr42 commented Dec 21, 2019

TODO: Update in https://github.com/deegree/deegree3/wiki/End-of-Life-and-Support-Matrix to SQL Server 2017/SQL Server 14.0 and SQL Server 2012/SQL Server 11.0 for 3.4 after PR was merged.

@tfr42 tfr42 added the dependencies Pull requests that update a dependency (library) label Mar 6, 2020
@copierrj copierrj merged commit 84abc81 into deegree:master Mar 16, 2022
@tfr42 tfr42 added this to the 3.4.27 milestone Mar 17, 2022
@lgoltz lgoltz deleted the feature/upgradeMSSQLDriver branch December 8, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency (library) enhancement enhancement or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants