Enhance FeatureInspector with the context of the transaction, if available #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a FeatureStoreTransaction (changes are backwards compatible, default interface extension)
|
Last build (5) ran without issue see https://buildserver.deegree.org/blue/organizations/jenkins/deegree-3.4%2Fpull-request/detail/PR-1290/5/pipeline |
|
Postponed because the actual change to use the new interface was pushed to another pr, but was supposed to be included in this one. |
stephanr
commented
Apr 13, 2022
| @@ -556,7 +560,7 @@ public List<String> performInsert( FeatureCollection fc, IDGenMode mode ) | |||
| for ( FeatureInspector inspector : inspectors ) { | |||
| for ( Feature f : features ) { | |||
| // TODO cope with inspectors that return a different instance | |||
| inspector.inspect( f ); | |||
| inspector.inspect( f, this ); | |||
There was a problem hiding this comment.
Comment #1290 (comment)
Postponed because the actual change to use the new interface was pushed to another pr, but was supposed to be included in this one.
After a new review, it turned out that all affected changes are already included.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the FeatureInspector in a backwards compatible way (default interface) to give the feature inspection, if available, more context information.