Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gke deployment #19

Merged
merged 5 commits into from Jul 1, 2021
Merged

Gke deployment #19

merged 5 commits into from Jul 1, 2021

Conversation

deep-diver
Copy link
Owner

No description provided.

Copy link
Collaborator

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @deep-diver. I have just left a few questions I need clarification on.

@sayakpaul
Copy link
Collaborator

@deep-diver final question is on MemoryStore.

As per this document, we need to enable VPC Native during the creation of the clusters. Is this incorporated currently or how are we handling it?

@deep-diver
Copy link
Owner Author

@deep-diver final question is on MemoryStore.

As per this document, we need to enable VPC Native during the creation of the clusters. Is this incorporated currently or how are we handling it?

It seems like the version of GKE is almost always above 1.18 for these days, so we are ok with it. Another setting is to do something with iptables, however this is unnecessary if we put --enable-ip-alias option when creating GKE cluster with gcloud container clusters.

So I think if we create with --enable-ip-alias option, there is nothing to configure as long as MemoryStore is setup in the same Region.

@sayakpaul
Copy link
Collaborator

sayakpaul commented Jul 1, 2021

Yes, that's what I was coming to. So, how are we creating the clusters now? Are we manually executing that for the time being?

@deep-diver
Copy link
Owner Author

Yes, that's what I was coming to. So, how are we creating the clusters now? Are we manually executing that for the time being?

That depends on scenarios. In this project, it is assumed that a cluster is already created, then GitHub Action is going to just apply the updated docker image whenever there is any changes to server directory. Note that GitHub Action for GKE deployment is not setup yet

@sayakpaul
Copy link
Collaborator

Okay thank you. In the Google Doc (draft) I have shared a starter GitHub Action workflow that might be useful. Let me know.

@sayakpaul
Copy link
Collaborator

@deep-diver feel free to merge the PR :)

@deep-diver deep-diver merged commit 7acad70 into main Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants