Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Screenshots #2

Closed
deep-gaurav opened this issue Oct 2, 2018 · 15 comments
Closed

Add Screenshots #2

deep-gaurav opened this issue Oct 2, 2018 · 15 comments
Labels
good first issue Good for newcomers

Comments

@deep-gaurav
Copy link
Owner

Some Screenshots

screenshot from 2018-10-02 23-42-18
screenshot from 2018-10-02 23-43-15

@deep-gaurav
Copy link
Owner Author

Version 0.1.2-beta

screenshot_20181016_222507
screenshot_20181016_222800
screenshot_20181016_222839
screenshot_20181016_223403
screenshot_20181016_223451
screenshot_20181016_223510
screenshot_20181016_223531
Uploading Screenshot_20181016_231332.png…

@deep-gaurav
Copy link
Owner Author

Screenshots for v1.0.0+
(ignore ads for F-Droid version)

nexus 6p-screenshot1
nexus 6p-screenshot2
nexus 6p-screenshot3
nexus 6p-screenshot4
nexus 6p-screenshot5

@deep-gaurav
Copy link
Owner Author

Current screenshot shows ads, which isn't case anymore and might repel some people, they need to be changed with new/better screenshot, and if possible add in F-Droid since I don't know how to do that, help would be appreciated.,

https://f-droid.org/en/docs/All_About_Descriptions_Graphics_and_Screenshots/

Some help can be found here

@deep-gaurav deep-gaurav added the good first issue Good for newcomers label Feb 23, 2019
@deep-gaurav
Copy link
Owner Author

Screenshots will need update with v1.1

@Poussinou
Copy link

Poussinou commented Mar 13, 2019

Hi, F-Droid contributor here.

To add the screenshots, just follow this guide. We prefer to host the screenshots in the original source repo. The fdroiddata repo is already too big.

Basically, you can add a fastlane directory at the root of your repo. Just follow the example of Newpipe. As you can see, you can also directly add the descriptions, and a changelog that will be shown directly on F-Droid website like this one and in the client.

Please be sure to do that before tagging the next release, so that screenshots can appear with the next update that our bot will build.

EDIT: you don't need to actually use fastlane yourself, it's just the directory structure that we use at F-Droid to find the screenshots ;)

@Poussinou
Copy link

Poussinou commented Mar 13, 2019

Totally off-topic, but your app actually violates the terms of use of Google Play, because it allows to stream audio from youtube without using the app or something else, and because you can close your phone and still have the audio (coming from youtube) in the background. You can get a strike for that if Google find your app, just to let you know...

@deep-gaurav
Copy link
Owner Author

@Poussinou Thanks for help,.

And regarding play store, I'm aware of it and actually Google too, they blocked my Adsense account and do not allow me to update app, I wish to remove ad from that version but can't since Google is rejecting updates. It's still better then complete ban atleast I try to redirect PPL from play store to F-Droid.

@Poussinou
Copy link

How, I thought Google wouldn't let the app online. Looks very weird, but ok...

Obviously your app is welcome at F-Droid, and I personally use it a lot :)

@deep-gaurav
Copy link
Owner Author

Btw, out of context, but it has been ~3 days since I posted last update which was kind of major and had many fixes,. It doesn't seem to be updated on F-Droid yet

@Poussinou
Copy link

As you can see here, our bot knows there is an update, but it's not build yet, or not yet signed. We lack some humans at F-Droid to speed up things. I hope it should appear today or tomorrow.

@deep-gaurav
Copy link
Owner Author

deep-gaurav commented Mar 14, 2019 via email

@Poussinou
Copy link

It usually takes a few days

I assume we use stable version, as you can see in the metadate file srclibs: - flutter@v1.2.1

@Rudloff can you confirm?

@Rudloff
Copy link

Rudloff commented Mar 14, 2019

Yes, we currently use Flutter 1.2.1 for this app. If new versions require another Flutter version, we will have to update the metadata.

However, 1.1 failed to build because Flutter does not like the version name.

@deep-gaurav
Copy link
Owner Author

deep-gaurav commented Mar 14, 2019

Updated the version for flutters liking and drafted release, hopefully it builds

The problem is that my device got stolen recently and current one is a very old device which doesn't even recognise PC.

So only way for me to work is use AVD, which doesn't support flutter release since it's ARM only. and debug version doesn't translate well to release.

And so these little mistakes get pass

@deep-gaurav
Copy link
Owner Author

@Poussinou I added screenshots following NewPipe pattern in fastlane hierarchy in root folder. Will there need to be changes in fdroiddata to reflect it or will it auto update.

Also is it possible to add donation link in fdroiddata. https://github.com/deep-gaurav/MusicPiped#donate will be nice enough as website no longer exist, since I dont have domain anymore.

It would also be great if website link can be removed from fdroidentry for aforementioned reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants