Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two arguments to arc must be boolean. #19

Merged
merged 2 commits into from Jan 26, 2016

Conversation

Projects
None yet
2 participants
@mmachenry
Copy link
Contributor

commented Jan 21, 2016

I've noticed that using the same "Show a => a -> a -> a" mechanism used on the rest of the functions in this module does not work for arcs. In the event that 'a' is an integer, it works fine. But as soon as you need to use a float, the two flag arguments become "0.0" or "1.0" and that is not valid SVG. I'm changing them to require booleans.

@@ -194,8 +194,8 @@ aa
=> a -- ^ Radius in the x-direction
-> a -- ^ Radius in the y-direction
-> a -- ^ The rotation of the arc's x-axis compared to the normal x-axis
-> a -- ^ Draw the smaller or bigger arc satisfying the start point
-> a -- ^ To mirror or not
-> Bool -- ^ Draw the smaller or bigger arc satisfying the start point

This comment has been minimized.

Copy link
@byorgey

byorgey Jan 23, 2016

Collaborator

Could you clarify in the documentation which of (True, False) corresponds to (smaller, bigger)?

@byorgey

This comment has been minimized.

Copy link
Collaborator

commented Jan 23, 2016

Thanks, makes sense! It might be nice to clarify the documentation a tiny bit as I noted in a comment above.

@mmachenry

This comment has been minimized.

Copy link
Contributor Author

commented Jan 25, 2016

Good idea, I clarified the documentation.

byorgey added a commit that referenced this pull request Jan 26, 2016

Merge pull request #19 from mmachenry/correct-arc-flags
Two arguments to arc must be boolean.

@byorgey byorgey merged commit 8ba149e into deepakjois:master Jan 26, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@byorgey

This comment has been minimized.

Copy link
Collaborator

commented Jan 26, 2016

Uploaded as 0.3.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.