Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #26: add user-info component #31

merged 1 commit into from Nov 30, 2018


Copy link

pynnl commented Nov 28, 2018

Fixes #26
Libs used: moment & moment-precise-range


@pynnl pynnl force-pushed the pynnl:issue-26 branch from 176926a to 2012799 Nov 30, 2018

This comment has been minimized.

Copy link

jkmdev commented Nov 30, 2018

LGTM! The only thing I'd really comment on is that there's a slight performance hit when loading data into the component, might be related to all the different api calls being made. At any rate it's not something that needs to be pursued for now or even for the next while, so I'll just merge this in. Thanks for doing this, looks great!

@jkmdev jkmdev merged commit 7fd41e7 into deepanjali19:master Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.