From 569531dfd8071837656f976d2e6690da25d443fd Mon Sep 17 00:00:00 2001
From: Itay Gabbay <itay@deepchecks.com>
Date: Mon, 6 Dec 2021 10:57:47 +0200
Subject: [PATCH] fixing comments

---
 makefile | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/makefile b/makefile
index 7cf620ed91..acf6f58b8a 100644
--- a/makefile
+++ b/makefile
@@ -52,8 +52,8 @@ REQUIREMENTS_LOG := .requirements.log
 ANALIZE_PKGS = pylint pydocstyle 
 TEST_CODE := tests/
 TEST_RUNNER_PKGS = pytest pytest-cov pyhamcrest nbval
-NOTEBOOK_DIR = ./notebooks/checks
-NB_EXAMPLES = ./notebooks/examples/**/*.ipynb
+NOTEBOOK_CHECKS = ./notebooks/checks
+NOTEBOOK_EXAMPLES = ./notebooks/examples/**/*.ipynb
 NOTEBOOK_SANITIZER_FILE= ./notebooks/.nbval-sanitizer
 
 PYLINT_LOG = .pylint.log
@@ -136,8 +136,8 @@ notebook: $(REQUIREMENTS_LOG) $(TEST_RUNNER)
 # deepchecks in development mode
 	$(PIP) install --no-deps -e .
 # Making sure the examples are running, without validating their outputs.
-	$(JUPYTER) nbconvert --execute $(NB_EXAMPLES) --to notebook --stdout > /dev/null
-	$(pythonpath) $(TEST_RUNNER) --nbval $(NOTEBOOK_DIR) --sanitize-with $(NOTEBOOK_SANITIZER_FILE)
+	$(JUPYTER) nbconvert --execute $(NOTEBOOK_EXAMPLES) --to notebook --stdout > /dev/null
+	$(pythonpath) $(TEST_RUNNER) --nbval $(NOTEBOOK_CHECKS) --sanitize-with $(NOTEBOOK_SANITIZER_FILE)
 $(TEST_RUNNER):
 	$(PIP) install $(TEST_RUNNER_PKGS) | tee -a $(REQUIREMENTS_LOG)
 
@@ -298,7 +298,7 @@ download:
 	$(PIP) install $(PROJECT)
 
 jupyter: $(JUPYTER)
-	$(BIN)/jupyter-notebook $(args) --notebook-dir=$(NOTEBOOK_DIR)
+	$(BIN)/jupyter-notebook $(args) --notebook-dir=$(NOTEBOOK_CHECKS)
 
 $(JUPYTER):
 	$(PIP) install jupyter