You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The CI system is really complex to understand right now. I'm typing up some notes here to help me and the other reviewers so we can better keep track of code state. This should also be useful to new developers so they can self-check PRs. We should merge these notes into the docs later.
The CI has several stages of checks:
Build: These are the absolute basic tests that check if DeepChem can be installed and imported after the PR is merged. If these tests fail, there's something terribly wrong and the PR absolutely shouldn't be merged.
Core: This should be renamed something like "Developer tools test". It consists of flake8/doctest/mypy checks. These checks should also not fail in a PR. We've been bad about keeping track of this but I'll try to fix this moving forward. If PR fails Core tests, it shoudn't be merged in.
Common: These are all the non backend (that is no Jax/PyTorch/TF usage) tests. These should also pass most of the time.
Jax/Torch/TensorFlow: These different runs respectively only test Jax/Torch/TensorFlow tests. Most flaky tests will reside in one of these runs and have to do something with a numerical issue from a deep learning backend. It may be OK to merge a PR even if it fails a test here and we have some lingering breakages here we're trying to fix (the challenge is that each backend version bump introduces slight numerical changes which can break our correctness tests)
The text was updated successfully, but these errors were encountered:
The CI system is really complex to understand right now. I'm typing up some notes here to help me and the other reviewers so we can better keep track of code state. This should also be useful to new developers so they can self-check PRs. We should merge these notes into the docs later.
The CI has several stages of checks:
The text was updated successfully, but these errors were encountered: