Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently did custom modifications of this plugin for a client. Thought you might benefit from some tests I've created in the process.
The following tests are added:
build_url- which refactors this code into a function to test itbuild_responseI also have a test for
vendor_params::from_header_arraybut that changes theDockerfileandbuild.rsquite a bit to remove theMRCP_INCLUDE_PATHenv variable whichcargo testdoes not detect. Will you be ok with changing these two files?Technically a test step can also be added to github actions...