Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tests #68

Merged
merged 2 commits into from
Sep 27, 2021
Merged

Some tests #68

merged 2 commits into from
Sep 27, 2021

Conversation

chesedo
Copy link
Contributor

@chesedo chesedo commented Sep 24, 2021

I recently did custom modifications of this plugin for a client. Thought you might benefit from some tests I've created in the process.

The following tests are added:

  • build_url - which refactors this code into a function to test it
  • build_response

I also have a test for vendor_params::from_header_array but that changes the Dockerfile and build.rs quite a bit to remove the MRCP_INCLUDE_PATH env variable which cargo test does not detect. Will you be ok with changing these two files?

Technically a test step can also be added to github actions...

@adeschamps
Copy link
Contributor

Thank you for the contribution! At a glance this looks great. I'll take a closer look in the next day or two, and then merge this.

@adeschamps adeschamps merged commit fccef4c into deepgram:master Sep 27, 2021
@adeschamps
Copy link
Contributor

This is great, thank you.

As for the other test you mentioned -- I'm totally open to changes to Dockerfile and build.rs. The include path env variable works on the systems that I've tested with (Ubuntu and CentOS) but if a more flexible and/or portable setup is possible, then I'd gladly accept a contribution.

@chesedo chesedo mentioned this pull request Oct 5, 2021
@chesedo chesedo deleted the Tests branch October 14, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants