From 570bd338dc184b0bd911de1db75f796798fa873b Mon Sep 17 00:00:00 2001 From: DJ Majumdar Date: Wed, 18 Mar 2026 06:44:21 -0700 Subject: [PATCH] fix(ci): restore stderr capture for benchmark output on main MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR #48 accidentally reverted the `2>&1` fix from PR #47. Criterion writes bencher-format output to stderr, so `2>/dev/null` was silently discarding it, leaving bench-output.txt empty on push-to-main runs. The github-action-benchmark step only runs on push events, so PR runs never exercised the broken path — the failure only surfaced after merge. --- .github/workflows/benchmarks.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml index 11adf31..8749bc9 100644 --- a/.github/workflows/benchmarks.yml +++ b/.github/workflows/benchmarks.yml @@ -32,7 +32,7 @@ jobs: run: cargo bench --all-features --no-run - name: Run benchmarks - run: cargo bench --all-features -- --save-baseline current --output-format bencher 2>/dev/null | tee bench-output.txt + run: cargo bench --all-features -- --save-baseline current --output-format bencher 2>&1 | tee bench-output.txt # ── Push to main: update timeline + cache baseline ──