This repository has been archived by the owner. It is now read-only.

Make lombok artifact optional in pom.xml files #538

merged 1 commit into from Mar 27, 2018


None yet
2 participants
Copy link

saudet commented Mar 27, 2018

Fixes deeplearning4j/deeplearning4j#4839

What changes were proposed in this pull request?

Prevent Lombok from leaking to dependent projects, update version, and rearrange dependencies as required because no longer transitive.

How was this patch tested?

Build passes, running LenetMnistExample from dl4j-examples works, and confirmed manually on it that mvn dependency:tree does not contain lombok anymore.

@saudet saudet requested a review from AlexDBlack Mar 27, 2018

Copy link

AlexDBlack left a comment


Dependency tree looks fine.

@AlexDBlack AlexDBlack merged commit 99a1f70 into master Mar 27, 2018

1 check failed

continuous-integration/jenkins/pr-merge This commit cannot be built

@AlexDBlack AlexDBlack deleted the sa_maven branch Mar 27, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.