This repository has been archived by the owner. It is now read-only.

Remove reflections library #570

merged 9 commits into from Apr 26, 2018


None yet
1 participant
Copy link

AlexDBlack commented Apr 26, 2018

PR: Removes the reflections library from DataVec.

This requires changing the JSON format for subtypes, from a wrapper object to an @class field. Without doing this (i.e., if we kept the old format), custom transforms, conditions, etc would not be deserializable from JSON.

Much of this PR involves support for loading the legacy JSON format - i.e., loading transforms etc from JSON that were saved in 1.0.0-alpha or before (i.e., before this PR changed the JSON format)

@AlexDBlack AlexDBlack merged commit 09c6390 into master Apr 26, 2018

1 check failed

continuous-integration/jenkins/pr-merge This commit has test failures

@AlexDBlack AlexDBlack deleted the ab_reflections branch Apr 26, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.