New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SequenceRecordReaderDataSetIterator calls preProcess twice per next() #4103

Closed
lilalinux opened this Issue Sep 22, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@lilalinux
Copy link

lilalinux commented Sep 22, 2017

Issue Description

SequenceRecordReaderDataSetIterator calls preProcess twice per next()
It's called already at the ed of mdsToDataSet() and directly after it returns again:

private DataSet mdsToDataSet(MultiDataSet mds) {
...
    if (preProcessor != null) {
        preProcessor.preProcess(ds);
    }

    return ds;
}
...
public DataSet next(int num) {
...
    DataSet ds = mdsToDataSet(mds);

    if (preProcessor != null) {
        preProcessor.preProcess(ds);
    }
...
}

Version Information

Current master
https://github.com/deeplearning4j/deeplearning4j/blob/master/deeplearning4j-core/src/main/java/org/deeplearning4j/datasets/datavec/SequenceRecordReaderDataSetIterator.java#L331

Contributing

Fix: #4104

@AlexDBlack

This comment has been minimized.

Copy link
Member

AlexDBlack commented Sep 25, 2017

@AlexDBlack AlexDBlack closed this Sep 25, 2017

@lock

This comment has been minimized.

Copy link

lock bot commented Sep 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Sep 24, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.