New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComputationGraph#addListeners only works for first listener #5251

Closed
DrChainsaw opened this Issue May 20, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@DrChainsaw
Copy link
Contributor

DrChainsaw commented May 20, 2018

Issue Description

Expected behaviour: addListeners is supposed to add the given listener(s) to existing listeners.

Observed behaviour: Given listeners are only set in ComputationGraphs trainingListeners in case no listeners where set before (if trainingListeners == null). Furthermore, it seems like existing listeners in solver and the solvers optimizer are overwritten. Probably easier to understand what is the problem if one just looks at the code :)

Version Information

  • Deeplearning4j version 1.0.0-beta and current master

Contributing

Would be trivial to add them but there might be other magic going on with layers and solver listeners which needs special attention.

@AlexDBlack AlexDBlack added this to the DL4J/Arbiter/DataVec Planning Sprint (01 June) milestone May 20, 2018

@lock

This comment has been minimized.

Copy link

lock bot commented Sep 22, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Sep 22, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.