New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataVec: improve errors/validation for images with centers outside of grid #6101

Closed
AlexDBlack opened this Issue Aug 7, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@AlexDBlack
Copy link
Member

AlexDBlack commented Aug 7, 2018

outLabel.putScalar(exampleNum, 0, imgGridY, imgGridX, tlPost[0]);
outLabel.putScalar(exampleNum, 1, imgGridY, imgGridX, tlPost[1]);
outLabel.putScalar(exampleNum, 2, imgGridY, imgGridX, brPost[0]);
outLabel.putScalar(exampleNum, 3, imgGridY, imgGridX, brPost[1]);

Currently: if image center is outside of image/grid, user gets an obscure array index exception.

@AlexDBlack AlexDBlack self-assigned this Aug 29, 2018

AlexDBlack added a commit that referenced this issue Aug 29, 2018

AlexDBlack added a commit that referenced this issue Aug 30, 2018

DL4J: Misc fixes (#6302)
* Another pass on javadoc link formatting

* #6299 Mnist iterator subset shuffling repeatability

* #6128 fix StackVertex output type

* #6101 DataVec ObjectDetectionRecordReader image center validation

* #6280 validate and throw exception for invalid loss/activation combinations

* Cleanup and fix tests given new validation

* Another round of javadoc link fixes

* Re-enable some now passing tests

* Tweak arbiter max candidates condition to exclude queued candidates

* Small final test fix

sshepel added a commit that referenced this issue Aug 30, 2018

DL4J: Misc fixes (#6302)
* Another pass on javadoc link formatting

* #6299 Mnist iterator subset shuffling repeatability

* #6128 fix StackVertex output type

* #6101 DataVec ObjectDetectionRecordReader image center validation

* #6280 validate and throw exception for invalid loss/activation combinations

* Cleanup and fix tests given new validation

* Another round of javadoc link fixes

* Re-enable some now passing tests

* Tweak arbiter max candidates condition to exclude queued candidates

* Small final test fix
@lock

This comment has been minimized.

Copy link

lock bot commented Sep 29, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Sep 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.