New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libnd4j: boolean_and/or op crash #6158

Closed
AlexDBlack opened this Issue Aug 14, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@AlexDBlack
Copy link
Member

AlexDBlack commented Aug 14, 2018

Both boolean_and and boolean_or ops are crashing on the following:

    @Test
    public void testBooleanAnd(){
        INDArray arr1 = Nd4j.create(new long[]{3,4});
        INDArray arr2 = Nd4j.create(new long[]{3,4});
        INDArray out = Nd4j.create(new long[]{3,4});

        DynamicCustomOp op = DynamicCustomOp.builder("boolean_and")
                .addInputs(arr1, arr2)
                .addOutputs(out)
                .build();
        Nd4j.getExecutioner().exec(op);
    }

Crash log:
https://gist.github.com/AlexDBlack/c82ccfbf6cd7febd298b22e950fa82d9

(Happens for both float and double precision)

Edit, unrelated: this line looks wrong (wrong op) for both ops:

@AlexDBlack

This comment has been minimized.

Copy link
Member

AlexDBlack commented Aug 14, 2018

Oh, and we don't have a boolean_xor op. Need this one too as a broadcastable op.

@raver119

This comment has been minimized.

Copy link
Contributor

raver119 commented Aug 14, 2018

Hm. Good catch.

raver119 added a commit that referenced this issue Aug 14, 2018

@raver119 raver119 referenced this issue Aug 14, 2018

Merged

bool ops #6160

@raver119 raver119 self-assigned this Aug 14, 2018

raver119 added a commit that referenced this issue Aug 15, 2018

bool ops (#6160)
* fix for #6158

* couple of tests

* minor fix
@raver119

This comment has been minimized.

Copy link
Contributor

raver119 commented Aug 15, 2018

Fixed now, and xor + not were added as well.

@AlexDBlack

This comment has been minimized.

Copy link
Member

AlexDBlack commented Aug 15, 2018

Confirmed fixed - thanks!

@AlexDBlack AlexDBlack closed this Aug 15, 2018

@lock

This comment has been minimized.

Copy link

lock bot commented Sep 21, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Sep 21, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.