New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libnd4j: embedding_lookup op needs to support multiple input arrays #6311

Closed
AlexDBlack opened this Issue Aug 30, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@AlexDBlack
Copy link
Member

AlexDBlack commented Aug 30, 2018

Currently, the embedding_lookup op assumes that all data is in a single array.
i.e., we have exactly 2 arrays: input and indices.

NDArray<T>* input = INPUT_VARIABLE(0); // lookup param
NDArray<T>* indeces = INPUT_VARIABLE(1); // indeces, as is

For TF import, we need this op (or a new op, if that's easier) to support multiple input arrays - i.e., a "split" input array (still with single indices array), with partitioning strategies "mod" and "div":
https://www.tensorflow.org/api_docs/python/tf/nn/embedding_lookup

@lock

This comment has been minimized.

Copy link

lock bot commented Oct 10, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Oct 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.