New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ND4J: SimpleFileVisitor not available on Android? #6609

Closed
AlexDBlack opened this Issue Oct 18, 2018 · 6 comments

Comments

Projects
None yet
2 participants
@AlexDBlack
Copy link
Member

AlexDBlack commented Oct 18, 2018

Not sure why we've never seen this before, but it might be worth looknig into this...
From stack trace here: #6608

Rejecting re-init on previously-failed class java.lang.Class<org.nd4j.versioncheck.VersionCheck$1>: java.lang.NoClassDefFoundError: Failed resolution of: Ljava/nio/file/SimpleFileVisitor;
at void org.nd4j.versioncheck.VersionCheck.checkVersions() (VersionCheck.java:89)
at void org.nd4j.linalg.factory.Nd4j.initWithBackend(org.nd4j.linalg.factory.Nd4jBackend) (Nd4j.java:5458)
at void org.nd4j.linalg.factory.Nd4j.initContext() (Nd4j.java:5447)
@saudet

This comment has been minimized.

Copy link
Member

saudet commented Oct 18, 2018

It's available from Android 8.0 onwards so I wouldn't worry about it too much:
https://developer.android.com/reference/java/nio/file/SimpleFileVisitor

@AlexDBlack

This comment has been minimized.

Copy link
Member

AlexDBlack commented Oct 18, 2018

Android 8.0 was is only 13 months old (general availability) according to my quick search - is that really enough for backward compatibility?
https://en.wikipedia.org/wiki/Android_Oreo
8.0 minimum cuts out the majority of users, if this is to be believed... https://developer.android.com/about/dashboards/

@saudet

This comment has been minimized.

Copy link
Member

saudet commented Oct 19, 2018

Wait, that's in the version check? Did you change that recently?

@saudet

This comment has been minimized.

Copy link
Member

saudet commented Oct 20, 2018

Strange, I guess we should at least add a catch block there and not fail in the event that this class doesn't load.

@saudet saudet added Bug ND4J labels Oct 20, 2018

@AlexDBlack AlexDBlack self-assigned this Oct 25, 2018

AlexDBlack added a commit that referenced this issue Oct 25, 2018

AlexDBlack added a commit that referenced this issue Oct 25, 2018

AlexDBlack added a commit that referenced this issue Oct 26, 2018

DL4J Issues/Fixes (#6634)
* #6611 Allow nets with more than Integer.MAX_VALUE params; fixes for indexing in large arrays

* Ignore annotation on new tests due to memory requirements

* #6609 Android compatibility for VersionCheck (remove use of SimpleFileVisitor)

* #6619 BarnesHutTsne.saveAsFile tweak

* #6632 Nd4j readTxt validation + extra tests

* Different fix for #6609

* Small stats listener tweak

* Small test fix
@lock

This comment has been minimized.

Copy link

lock bot commented Nov 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Nov 25, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.