New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ND4J: ReadTxt Issue #6632

Closed
boing102 opened this Issue Oct 24, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@boing102
Copy link

boing102 commented Oct 24, 2018

Hi,

I came across unexpected and incorrect behaviour of readTxt function. I have a file:

{
"filefrom:" "dl4j",
"ordering:" "c",
"shape":	[6, 3, 1],
"data":
[[0.00 ,   0.00 ,   0.00] ,   

 [0.00 ,   0.00 ,   0.00] ,   

 [420.00 ,   420.00 ,   420.00] ,   

 [420.00 ,   420.00 ,   420.00] ,   

 [0.00 ,   0.00 ,   0.00] ,   

 [0.00 ,   0.00 ,   0.00]]
}

When I print NDArray initiated by using the readTxt function it returns this:

[[0.00,  0.00,  420.00],  

 [420.00,  0.00,  0.00],  

 [0.00,  0.00,  0.00],  

 [0.00,  0.00,  0.00],  

 [0.00,  0.00,  0.00],  

 [0.00,  0.00,  0.00]]

Version Information
nd4j-native-platform - 0.9.1
OS - Ubuntu 18.04.1 LTS

@AlexDBlack AlexDBlack self-assigned this Oct 25, 2018

AlexDBlack added a commit that referenced this issue Oct 25, 2018

@AlexDBlack

This comment has been minimized.

Copy link
Member

AlexDBlack commented Oct 25, 2018

Thanks for reporting - I looked into this, and it seems the format you provide doesn't match the shape/output produced by 1.0.0-beta2. I've added a check for this case plus have added some extra tests here: #6634
It's quite possible that the format has been changed/fixed since 0.9.1.

FYI we're on 1.0.0-beta2 now - I'd suggest upgrading for a lot of bug fixes, new features and performance improvements.

AlexDBlack added a commit that referenced this issue Oct 26, 2018

DL4J Issues/Fixes (#6634)
* #6611 Allow nets with more than Integer.MAX_VALUE params; fixes for indexing in large arrays

* Ignore annotation on new tests due to memory requirements

* #6609 Android compatibility for VersionCheck (remove use of SimpleFileVisitor)

* #6619 BarnesHutTsne.saveAsFile tweak

* #6632 Nd4j readTxt validation + extra tests

* Different fix for #6609

* Small stats listener tweak

* Small test fix
@boing102

This comment has been minimized.

Copy link

boing102 commented Oct 26, 2018

Thanks for the suggestion.

Actually the reason I went back to version 0.9.1 was this: deeplearning4j/dl4j-examples#755

I completely forgot to put move the issue into this repository.

@lock

This comment has been minimized.

Copy link

lock bot commented Nov 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Nov 25, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.