Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SameDiff: Fix TensorArray execution support, add tests #6972

Closed
AlexDBlack opened this issue Jan 10, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@AlexDBlack
Copy link
Member

commented Jan 10, 2019

Turns out we don't have any TF import tests (other than SSD models) that actually use TensorArray.
Consequently, TensorArray support was missed in the SameDiff execution rewrite (though I don't think it was well tested in the old implementation anyway, give the lack of tests).

Not sure about libnd4j execution, but changes may also be required there.

Edit: there are some TensorArray tests here (not integrated into op validation suite hence not counted for coverage) - including a number of ignored ones that should be cleaned up:
https://github.com/deeplearning4j/deeplearning4j/blob/master/nd4j/nd4j-backends/nd4j-tests/src/test/java/org/nd4j/imports/TensorFlowImportTest.java

@lock

This comment has been minimized.

Copy link

commented Feb 10, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Feb 10, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.