Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
AsyncDataSetIterator not used by default when using an EarlyStoppingTrainer #7190
When using an EarlyStoppingTrainer, the trainer itself calls next() on the provided DataSetIterator and then fit(dataset) on the MultiLayerNetwork. This means we do not get the benefit of the AsyncDataSetIterator by default, and have to wrap the provided iterator manually before passing to EarlyStoppingTrainer.
This might be by design, but I thought I'd raise this issue in case it isn't. When I read that MultiLayerNetwork uses AsyncDataSetIterator by default, I expected that to be the case even when using EarlyStoppingTrainer.
Suggest updating EarlyStoppingTrainer or updating documentation on EarlyStoppingTrainer to suggest wrapping the provided iterator with an AsyncDataSetIterator.