New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aliases for conv and pooling layers #4026

Merged
merged 1 commit into from Sep 8, 2017

Conversation

Projects
None yet
1 participant
@maxpumperla
Copy link
Contributor

maxpumperla commented Sep 7, 2017

We're currently a little inconsistent in our naming convention for config layers, sometimes having a Layer suffix, e.g. LSTM vs. BaseRecurrentLayer. I'm personally in favour of dropping the suffix, everyone knows those are layers. Makes for a more concise API.

Here we're sub-classing:
SubsamplingLayer --> Pooling2D
Subsampling1DLayer --> Pooling2D
ConvolutionLayer --> Convolution2D
Convolution1DLayer --> Convolution1D

@agibsonccc are we OK with this?

@maxpumperla maxpumperla merged commit ecfd11e into master Sep 8, 2017

@maxpumperla maxpumperla deleted the mp_pooling_override branch Sep 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment