New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor BaseStatsListener to do some calculations in-line (requires less memory) #4292

Merged
merged 1 commit into from Nov 19, 2017

Conversation

Projects
None yet
3 participants
@AlexDBlack
Copy link
Member

AlexDBlack commented Nov 13, 2017

Addresses: #4271

@AlexDBlack AlexDBlack requested a review from crockpotveggies Nov 13, 2017

@@ -222,59 +228,71 @@ public void onEpochEnd(Model model) {
@Override
public void onForwardPass(Model model, List<INDArray> activations) {
int iterCount = getModelInfo(model).iterCount;
if (storeActivations() && (iterCount == 0 || iterCount % updateConfig.reportingFrequency() == 0)) {
if (calcFromActivations() && (iterCount == 0 || iterCount % updateConfig.reportingFrequency() == 0)) {

This comment has been minimized.

@crockpotveggies

crockpotveggies Nov 13, 2017

Collaborator

Is this handled on a separate thread similar/same to as before?

This comment has been minimized.

@AlexDBlack

AlexDBlack Nov 14, 2017

Member

No, it's handled in the current thread, same as before. It just does it when the arrays are available, rather than duping + calculating all at one later.

@agibsonccc

This comment has been minimized.

Copy link
Member

agibsonccc commented Nov 18, 2017

Anything stopping us from merging this?

@crockpotveggies

This comment has been minimized.

Copy link
Collaborator

crockpotveggies commented Nov 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment