New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workspace defaults to configs - avoids NPE when loading older config from JSON #4593

Merged
merged 1 commit into from Feb 1, 2018

Conversation

Projects
None yet
1 participant
@AlexDBlack
Copy link
Member

AlexDBlack commented Feb 1, 2018

Something I ran into: older JSON configurations won't have a field for the workspace mode.
Under these circumstances, Jackson will set the missing values to the default - in this case, null. Which results in a NPE.
Now, older JSON will get the same default as everything else (separate) instead of giving NPE on forward or fit ops.

@AlexDBlack AlexDBlack merged commit 5442b30 into master Feb 1, 2018

0 of 2 checks passed

codeclimate Code Climate is analyzing this code.
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@AlexDBlack AlexDBlack deleted the ab_workspacedefaults branch Feb 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment