New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory corruption when using Hdf5Archive #4870

Merged
merged 1 commit into from Mar 29, 2018

Conversation

Projects
None yet
2 participants
@saudet
Copy link
Member

saudet commented Mar 29, 2018

Fixes issue #4769

What changes were proposed in this pull request?

Makes sure all HDF5 objects are deallocated in the proper order to keep it happy.

How was this patch tested?

Slightly updated unit tests pass without crashing. I actually let importWganDiscriminator() run for 10000 iterations without problems, but reduced it to 100 for this PR so it does not take too much time to run.

@saudet saudet requested a review from maxpumperla Mar 29, 2018

@AlexDBlack
Copy link
Member

AlexDBlack left a comment

LGTM - I can still easily produce a crash on master, but zero crashes on this branch (even if I increase the number of tests to 1000).

@AlexDBlack AlexDBlack merged commit e2f8b09 into master Mar 29, 2018

1 of 2 checks passed

codeclimate 4 issues to fix
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@AlexDBlack AlexDBlack deleted the sa_kerasfix branch Mar 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment