New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reflections library from UI etc #4950

Merged
merged 5 commits into from Apr 20, 2018

Conversation

Projects
None yet
2 participants
@AlexDBlack
Copy link
Member

AlexDBlack commented Apr 19, 2018

Partially addresses: #4672

This removes all reflections library use in DL4J except for the custom layer JSON ser/de component. That will be handled in a separate (more complex) PR.

@AlexDBlack AlexDBlack merged commit 63f48c6 into master Apr 20, 2018

1 of 2 checks passed

continuous-integration/jenkins/pr-merge This commit is being built
Details
codeclimate All good!
Details

@AlexDBlack AlexDBlack deleted the ab_reflections branch Apr 20, 2018

@printomi

This comment has been minimized.

For your information: I have run into this error, and it was not DL4J that was run from an uber-jar, but another third-party dependency I used. Removing this third-party uber-jar from my dependencies resolved the problem.

The documentation at https://deeplearning4j.org/visualization#issues could also include this situation.

This comment has been minimized.

Copy link
Member

AlexDBlack replied Dec 12, 2018

@printomi Thanks for the info. Could you please open an issue with more information?
https://github.com/deeplearning4j/deeplearning4j/issues

I'd be happy to add some more info (in the exception error message and website docs) but I'd need to know more about why certain dependencies are causing problems (and what dependencies are causing problems for you, if you can share that).

This comment has been minimized.

Copy link
Contributor

printomi replied Dec 13, 2018

@AlexDBlack I tracked down my issue and filed it here: #6852

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment