New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reflections use from JSON format #4956

Merged
merged 19 commits into from Apr 25, 2018

Conversation

Projects
None yet
2 participants
@AlexDBlack
Copy link
Member

AlexDBlack commented Apr 20, 2018

Addresses: #4672
Also adds 1.0.0-alpha regression tests.

This PR:

  • Removes Reflections library from JSON serialization/deserialization, and hence from DL4J entirely (other uses of reflections have already been removed)
  • In order to do this (effectively) the JSON format has been slightly changed for handling subtypes (from wrapper object to class annotation)
    • Full (automatic) backward compatability for loading legacy JSON for all built-in layers (etc) will remain (i.e., we'll still be able to load saved nets going back to 0.5.0 as before)
    • Backward compatibility for serialized custom layers (etc) is supported, but requires a simple custom registration of the custom classes

@AlexDBlack AlexDBlack force-pushed the ab_reflections2 branch from 3d5663e to 8b4bb1f Apr 24, 2018

@AlexDBlack AlexDBlack requested a review from maxpumperla Apr 25, 2018

@maxpumperla
Copy link
Contributor

maxpumperla left a comment

LGTM

@AlexDBlack AlexDBlack merged commit 860ec59 into master Apr 25, 2018

0 of 2 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
codeclimate 5 issues to fix
Details

@AlexDBlack AlexDBlack deleted the ab_reflections2 branch Apr 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment